fix: avoid using svc_src: m when service is among active integration defaults#17712
fix: avoid using svc_src: m when service is among active integration defaults#17712emmettbutler merged 138 commits intomainfrom
Conversation
BenchmarksBenchmark execution time: 2026-05-01 19:16:57 Comparing candidate commit 00c94e4 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 584 metrics, 4 unstable metrics. scenario:iastaspects-stringio_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:telemetryaddmetric-1-count-metric-1-times
|
brettlangdon
left a comment
brettlangdon
left a comment
There was a problem hiding this comment.
other than the perf feedback this lgtm
I did not review all snapshots, scanning the rough shape of changes makes sense to me though why they are changing here
brettlangdon
left a comment
brettlangdon
left a comment
There was a problem hiding this comment.
question/suggestion about implementation, but otherwise lgtm
rithikanarayan
left a comment
rithikanarayan
left a comment
There was a problem hiding this comment.
approved for serverless snapshots
dubloom
left a comment
dubloom
left a comment
There was a problem hiding this comment.
My main question is:
Why some integrations remove _dd.svc_src if service == base_service and others are setting _dd.svc_src == service.
Also why are we deleting django snapshots ?
|
@dubloom django snapshots are deleted because the tests pass without them. Presumably this is because they are associated with tests that have been deleted. The cases where svc_src == service are because of inferred base service. |
wantsui
left a comment
wantsui
left a comment
There was a problem hiding this comment.
LGTM! I left some small comments about some of the snapshots.
…defaults (#17712) This change fixes an issue reported via Support in which `svc_src` is set to `m` in cases where `service` matches the `_default_service` of an active integration config. In such cases, the intended behavior is that it `svc_src` is equal to `service`. The change also excludes the `svc_src` tag in cases where `service == base_service`. --------- Co-authored-by: Yun Kim <yun.kim@datadoghq.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Rithika Narayan <rithika.narayan@datadoghq.com> Co-authored-by: Louis Tricot <75956635+dubloom@users.noreply.github.com> Co-authored-by: louis.tricot <louis.tricot@datadoghq.com> Co-authored-by: Thomas Kowalski <thomas.kowalski@datadoghq.com> Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com> Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com> Co-authored-by: gabriele.tornetta <gabriele.tornetta@datadoghq.com> Co-authored-by: Federico Mon <federico.mon@datadoghq.com> Co-authored-by: Alberto Vara <alberto.vara@datadoghq.com> Co-authored-by: kyle <kyle@verhoog.ca> Co-authored-by: ZStriker19 <32471391+ZStriker19@users.noreply.github.com> Co-authored-by: zach.groves <zach.groves@datadoghq.com> Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Gyuheon Oh <102937919+gyuheon0h@users.noreply.github.com> Co-authored-by: gyuheon.oh <gyuheon.oh@datadoghq.com> Co-authored-by: r1viollet <74836499+r1viollet@users.noreply.github.com> Co-authored-by: erwan.viollet <erwan.viollet@datadoghq.com>
16 participants
This change fixes an issue reported via Support in which
svc_srcis set tomin cases whereservicematches the_default_serviceof an active integration config. In such cases, the intended behavior is that itsvc_srcis equal toservice.The change also excludes the
svc_srctag in cases whereservice == base_service.